Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packaging: add pynvim.__version__ attribute (0.5.0.dev0) #540

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

wookayin
Copy link
Member

pynvim previously did not have the pynvim.__version__ attribute,
which is a popular convention for python modules.

We add the pynvim.__version__ string in addition to pynvim.VERSION,
and let pynvim._version be the only file that contains the version
metadata for the pynvim package. setup.py can also get the version
string from this file.

pynvim version is bumped up to 0.5.0.dev0 (from 0.4.3).

@wookayin wookayin force-pushed the version branch 2 times, most recently from acd4b27 to e4fcca4 Compare October 13, 2023 05:39
Copy link
Member

@justinmk justinmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great choices!

pynvim previously did not have the `pynvim.__version__` attribute,
which is a popular convention for python modules.

We add the `pynvim.__version__` string in addition to `pynvim.VERSION`,
and let `pynvim._version` be the only file that contains the version
metadata for the pynvim package. `setup.py` can also get the version
string from this file.

pynvim version is bumped up to a devel version: 0.5.0.dev0 (from 0.4.3).
@wookayin wookayin changed the title chore: Add pynvim.__version__ attribute (0.5.0.dev0) packaging: add pynvim.__version__ attribute (0.5.0.dev0) Oct 13, 2023
@justinmk justinmk merged commit 71d2d65 into neovim:master Oct 16, 2023
10 of 13 checks passed
@wookayin wookayin deleted the version branch October 16, 2023 19:29
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants