Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace mock package with unittest.mock #77

Closed
Chronial opened this issue Aug 8, 2016 · 6 comments
Closed

Replace mock package with unittest.mock #77

Chronial opened this issue Aug 8, 2016 · 6 comments

Comments

@Chronial
Copy link

Chronial commented Aug 8, 2016

From what I can see, this package does not support any version of python that does not come with mock in it's standardlib. Is there any reason not use that?

My main problem is that this lists mock as a requirement, which combined with pytest-dev/pytest-mock#54 now messes with my tests :).

@Chronial Chronial changed the title Replace mock package with unittests.mock Replace mock package with unittest.mock Aug 8, 2016
@yakky
Copy link
Member

yakky commented Aug 10, 2016

@Chronial isn't mock in stdlib only for python 3.3+ and up?

@Chronial
Copy link
Author

Oh, sorry – I must be doing to much python3 :). I for some reason thought it was also part of 2.7, but it is in fact not.

Would it be possible to only require mock on python2?

@yakky
Copy link
Member

yakky commented Aug 14, 2016

@Chronial choiould you check if #77 fixes the issue for you?

@Chronial
Copy link
Author

Yes, that looks great, thx :).

@yakky yakky closed this as completed in #78 Aug 15, 2016
@Chronial
Copy link
Author

@yakky It looks like this doesn't actually work, because you uploaded a py2+py3 wheel to pypi that states that it requires mock. The easiest solution to this would probably be to just not provide a wheel.

@yakky
Copy link
Member

yakky commented Oct 17, 2016

@Chronial my bad, an error in setup.py, fixed in #82
0.9.7 wheel will fix that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants