Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to latest django / django CMS #722

Merged
merged 29 commits into from
Apr 20, 2023
Merged

Conversation

yakky
Copy link
Member

@yakky yakky commented Feb 19, 2023

Description

  • Upgrade to Django 3.2+
  • Upgrade to django CMS 3.9+
  • Remove support for aldryn-search
  • Upgrade github actions

References

Fix #720

Checklist

  • I have read the contribution guide
  • Code lint checked via inv lint
  • changes file included (see docs)
  • Usage documentation added in case of new features
  • Tests added

@codecov
Copy link

codecov bot commented Feb 19, 2023

Codecov Report

Patch coverage: 94.73% and project coverage change: -0.27 ⚠️

Comparison is base (4647c47) 94.51% compared to head (ee71cd1) 94.25%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #722      +/-   ##
===========================================
- Coverage    94.51%   94.25%   -0.27%     
===========================================
  Files           21       26       +5     
  Lines         1112     1810     +698     
  Branches       138      260     +122     
===========================================
+ Hits          1051     1706     +655     
- Misses          23       52      +29     
- Partials        38       52      +14     
Flag Coverage Δ
unittests 94.25% <94.73%> (-0.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
djangocms_blog/cms_wizards.py 95.65% <ø> (ø)
djangocms_blog/taggit_urls.py 0.00% <0.00%> (ø)
djangocms_blog/__init__.py 100.00% <100.00%> (ø)
djangocms_blog/admin.py 83.06% <100.00%> (ø)
djangocms_blog/feeds.py 85.03% <100.00%> (ø)
djangocms_blog/liveblog/cms_plugins.py 95.23% <100.00%> (-4.77%) ⬇️
djangocms_blog/liveblog/consumers.py 100.00% <100.00%> (ø)
djangocms_blog/liveblog/models.py 96.55% <100.00%> (+0.06%) ⬆️
djangocms_blog/liveblog/routing.py 100.00% <100.00%> (ø)

... and 7 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yakky
Copy link
Member Author

yakky commented Feb 19, 2023

Fix #721

@yakky yakky force-pushed the feature/issue-720-upgrade branch from 9f783a6 to bc87247 Compare April 18, 2023 21:03
@yakky yakky force-pushed the feature/issue-720-upgrade branch from 86ff4bd to 92226fe Compare April 18, 2023 21:20
@yakky yakky force-pushed the feature/issue-720-upgrade branch from 08bbca6 to ee71cd1 Compare April 20, 2023 20:55
@yakky yakky merged commit 8b83fad into develop Apr 20, 2023
@yakky yakky mentioned this pull request May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for current django / django CMS versions
1 participant