Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for installing nonKIND cluster via kubeadm (previously PR #46) #296

Merged
merged 4 commits into from
Aug 20, 2024

Conversation

dkosteck
Copy link
Contributor

@dkosteck dkosteck commented Aug 15, 2024

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test

/kind feature

/kind flake

What this PR does / why we need it:
allows for installing nonKIND K8S cluster on ubuntu and fedora for e2e test cases (previously #46)

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
The linked PR authored by @vjayaramrh was automatically closed when the branch was merged/rebased, and does not reflect current files in kubeadm, so it has been linked for historical purposes/to review previous discussions.

Does this PR introduce a user-facing change?:

NONE

allows for installing nonKIND K8S cluster on ubuntu and fedora for e2e test cases
@dkosteck dkosteck requested a review from vjayaramrh August 15, 2024 20:37
@dkosteck dkosteck changed the title add support for installing nonKIND cluster via kubeadm (previously https://github.com/nephio-project/test-infra/pull/46) add support for installing nonKIND cluster via kubeadm (previously #46) Aug 15, 2024
@dkosteck dkosteck changed the title add support for installing nonKIND cluster via kubeadm (previously #46) add support for installing nonKIND cluster via kubeadm (previously PR #46) Aug 15, 2024
@dkosteck dkosteck marked this pull request as draft August 15, 2024 20:43
@vjayaramrh
Copy link
Collaborator

/test provision-linter

@dkosteck dkosteck marked this pull request as ready for review August 16, 2024 16:41
@dkosteck dkosteck marked this pull request as draft August 16, 2024 16:50
@dkosteck dkosteck marked this pull request as draft August 16, 2024 16:50
@dkosteck
Copy link
Contributor Author

This has now been tested on Fedora and the linter errors fixed, I squashed this as best as possible, but feel free to merge it with a squash if it ends up approved to get the log cleaner.

@dkosteck dkosteck marked this pull request as ready for review August 16, 2024 16:54
…ocations

Co-authored-by: Vishwanath Jayaraman <vjayaram@redhat.com>
@radoslawc
Copy link
Collaborator

/approve

Copy link
Contributor

nephio-prow bot commented Aug 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: radoslawc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label Aug 19, 2024
@dkosteck
Copy link
Contributor Author

/test e2e-free5gc-fedora-34

@vjayaramrh
Copy link
Collaborator

/test e2e-free5gc-fedora-34

- name: Hold kubectl
ansible.builtin.dpkg_selections:
name: kubectl
selection: hold
Copy link
Contributor

@arora-sagar arora-sagar Aug 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dkosteck

Updating my comment: My comment is only for workload cluster not for management cluster.

sudo sysctl vm.mmap_rnd_bits=28, earlier we had to do this for Ubuntu 22 on GCP which has the new 6.5-gcp kernel.

Reason: actions/runner-images#9491 (comment)

So for the OAI packages that we are using in R3 we have to do this, but with the newer OAI images, we don't need any changes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, the changes that this MR made, I don't think are tested in the CI.

@arora-sagar
Copy link
Contributor

/lgtm

@nephio-prow nephio-prow bot added the lgtm label Aug 20, 2024
@nephio-prow nephio-prow bot merged commit 4a828c2 into nephio-project:main Aug 20, 2024
7 checks passed
@vjayaramrh vjayaramrh deleted the kubeadm branch August 20, 2024 16:21
vjayaramrh added a commit to vjayaramrh/test-infra that referenced this pull request Aug 20, 2024
…ephio-project#46) (nephio-project#296)

* add support for installing nonKIND cluster via kubeadm

allows for installing nonKIND K8S cluster on ubuntu and fedora for e2e test cases

* Add support for installing nonKIND cluster via kubeadm, moving file locations

Co-authored-by: Vishwanath Jayaraman <vjayaram@redhat.com>

* Change yml file suffix in main

---------

Co-authored-by: vjayaramrh <vjayaram@redhat.com>
nephio-prow bot pushed a commit that referenced this pull request Aug 22, 2024
* add support for installing nonKIND cluster via kubeadm

allows for installing nonKIND K8S cluster on ubuntu and fedora for e2e test cases

* Add support for installing nonKIND cluster via kubeadm, moving file locations

Co-authored-by: Vishwanath Jayaraman <vjayaram@redhat.com>

* adds prow job to install Nephio components on kubeadm cluster

Co-authored-by: Daniel Kostecki <dkosteck@redhat.com>

* add support for installing nonKIND cluster via kubeadm (previously PR #46) (#296)

* add support for installing nonKIND cluster via kubeadm

allows for installing nonKIND K8S cluster on ubuntu and fedora for e2e test cases

* Add support for installing nonKIND cluster via kubeadm, moving file locations

Co-authored-by: Vishwanath Jayaraman <vjayaram@redhat.com>

* Change yml file suffix in main

---------

Co-authored-by: vjayaramrh <vjayaram@redhat.com>

* adds prow job to install nephio components on kubeadm cluster

Co-authored-by: Daniel Kostecki <dkosteck@redhat.com>

---------

Co-authored-by: Daniel Kostecki <dkosteck@redhat.com>
Co-authored-by: Daniel Kostecki <84861140+dkosteck@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants