add handling unsupported nans in stringifying_unsupported

CHANGELOG.md

@@ -21,7 +21,7 @@
 - Minor tweaks to `neptune.cli` and cleaning leftovers after async Experiments ([#1529](https://github.com/neptune-ai/neptune-client/pull/1529))
 - Pin `simplejson` required version to below `3.19` ([#1535](https://github.com/neptune-ai/neptune-client/pull/1535))
 - Added `experimental` mode that supports partitioned operations queue ([#1524](https://github.com/neptune-ai/neptune-client/pull/1524))
-
+- Added support for unsupported float values in `stringify_unsupported()` ([#1543](https://github.com/neptune-ai/neptune-client/pull/1543))
 
 ## neptune 1.8.2
 

src/neptune/common/warnings.py

@@ -19,6 +19,7 @@
     "NeptuneDeprecationWarning",
     "NeptuneWarning",
     "NeptuneUnsupportedType",
+    "NeptuneUnsupportedValue",
 ]
 
 import os
@@ -40,6 +41,10 @@ class NeptuneUnsupportedType(Warning):
     pass
 
 
+class NeptuneUnsupportedValue(Warning):
+    pass
+
+
 warnings.simplefilter("always", category=NeptuneDeprecationWarning)
 
 warned_once = set()

src/neptune/internal/types/stringify_value.py

@@ -29,8 +29,9 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 #
-__all__ = ["StringifyValue", "extract_if_stringify_value"]
+__all__ = ["StringifyValue", "extract_if_stringify_value", "is_unsupported_float"]
 
+import math
 from typing import Any
 
 from neptune.constants import (
@@ -40,6 +41,12 @@
 from neptune.internal.utils.logger import logger
 
 
+def is_unsupported_float(value) -> bool:
+    if isinstance(value, float):
+        return math.isinf(value) or math.isnan(value)
+    return False
+
+
 class StringifyValue:
     def __init__(self, value: Any):
         # check if it's an integer outside 32bit range and cast it to float
@@ -51,6 +58,13 @@ def __init__(self, value: Any):
                 MAX_32_BIT_INT,
             )
             value = float(value)
+        if is_unsupported_float(value):
+            logger.info(
+                "The value you're trying to log is an unsupported float value (%s) and will be logged as string. "
+                "We'll add support for these types of values in the future.",
+                str(value),
+            )
+            value = str(value)
 
         self.__value = value
 

tests/unit/neptune/new/test_stringify_unsupported.py

@@ -13,6 +13,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 #
+import math
 from contextlib import contextmanager
 from datetime import datetime
 from typing import (
@@ -531,3 +532,14 @@ def test_integers_outside_32bits(self, run):
 
         with assert_no_warnings():
             run["data"] = data
+
+    def test_stringifying_unsupported_floats(self, run):
+        with assert_no_warnings():
+            run["infinity"] = stringify_unsupported(float("inf"))
+            run["neg_infinity"] = stringify_unsupported(float("-inf"))
+            run["nan"] = stringify_unsupported(float("nan"))
+
+        assert run["infinity"].fetch() == "inf"
+        assert run["neg_infinity"].fetch() == "-inf"
+
+        assert math.isnan(float(run["nan"].fetch()))