add newline at the end of the diff file (#1473)

CHANGELOG.md

@@ -1,3 +1,8 @@
+## [UNRELEASED] neptune 1.7.1
+
+### Fixes
+- Add newline at the end of generated `.patch` while tracking uncommitted changes ([#1473](https://github.com/neptune-ai/neptune-client/pull/1473))
+
 ## neptune 1.7.0
 
 ### Features

src/neptune/internal/utils/git.py

@@ -134,7 +134,12 @@ def get_diff(repo: "git.Repo", commit_ref: str) -> Optional[str]:
         from git.exc import GitCommandError
 
         try:
-            return repo.git.diff(commit_ref, index=False)
+            diff = repo.git.diff(commit_ref, index=False)
+
+            # add a newline at the end (required to be a valid `patch` file)
+            if diff[-1] != "\n":
+                diff += "\n"
+            return diff
         except GitCommandError:
             return
     except ImportError:

tests/unit/neptune/new/internal/utils/test_git.py

@@ -205,9 +205,9 @@ def test_get_uncommitted_changes(mock_get_sha, mock_repo):
     # then
     assert mock_repo.git.diff.call_count == 2
     assert mock_get_sha.call_count == 1
-    assert uncommitted_changes.diff_head == "some_diff"
+    assert uncommitted_changes.diff_head == "some_diff\n"
     assert uncommitted_changes.upstream_sha == "test_sha"
-    assert uncommitted_changes.diff_upstream == "some_diff"
+    assert uncommitted_changes.diff_upstream == "some_diff\n"
 
 
 @patch("git.Repo")