Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use legacy wrapper in common package #1204

Merged
merged 4 commits into from
Feb 9, 2023
Merged

Conversation

aniezurawski
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Base: 79.56% // Head: 71.49% // Decreases project coverage by -8.08% ⚠️

Coverage data is based on head (c4348df) compared to base (bec4eb3).
Patch coverage: 61.90% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1204      +/-   ##
==========================================
- Coverage   79.56%   71.49%   -8.08%     
==========================================
  Files         286      288       +2     
  Lines       13605    13624      +19     
==========================================
- Hits        10825     9740    -1085     
- Misses       2780     3884    +1104     
Flag Coverage Δ
e2e ?
unit ?
unit-pull-request 71.49% <61.90%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/neptune/common/utils.py 71.85% <ø> (+2.28%) ⬆️
src/neptune/new/cli/commands.py 60.00% <ø> (-16.00%) ⬇️
src/neptune/new/cli/path_option.py 66.66% <ø> (-16.67%) ⬇️
src/neptune/new/exceptions.py 82.69% <ø> (+1.56%) ⬆️
...neptune/new/internal/value_to_attribute_visitor.py 94.02% <0.00%> (-1.50%) ⬇️
...y/internal/api_clients/hosted_api_clients/utils.py 41.17% <41.17%> (ø)
src/neptune/common/exceptions.py 63.15% <48.27%> (-26.13%) ⬇️
src/neptune/common/backends/utils.py 52.72% <52.72%> (ø)
src/neptune/common/envs.py 100.00% <100.00%> (ø)
src/neptune/common/oauth.py 80.82% <100.00%> (-5.29%) ⬇️
... and 115 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@@ -22,7 +22,6 @@
"NEPTUNE_ALLOW_SELF_SIGNED_CERTIFICATE",
"NEPTUNE_NOTEBOOK_ID",
"NEPTUNE_NOTEBOOK_PATH",
"NEPTUNE_RETRIES_TIMEOUT_ENV",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an import from common package here for backward compatibility.

@Raalsky Raalsky merged commit 6497bf0 into master Feb 9, 2023
@Raalsky Raalsky deleted the waj/move-wrapper branch February 9, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants