Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove init function #1216

Merged
merged 6 commits into from
Feb 13, 2023
Merged

Remove init function #1216

merged 6 commits into from
Feb 13, 2023

Conversation

AleksanderWWW
Copy link
Contributor

@AleksanderWWW AleksanderWWW commented Feb 13, 2023

Before submitting checklist

  • Did you update the CHANGELOG? (not for test updates, internal changes/refactors or CI/CD setup)
  • Did you asked the docs owner to review all the updated user-facing interfaces?

@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

Base: 71.35% // Head: 71.35% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (b4437a9) compared to base (2ad1958).
Patch has no changes to coverable lines.

Additional details and impacted files
@@              Coverage Diff              @@
##           dev/1.0.0    #1216      +/-   ##
=============================================
- Coverage      71.35%   71.35%   -0.01%     
=============================================
  Files            284      284              
  Lines          13652    13648       -4     
=============================================
- Hits            9742     9739       -3     
+ Misses          3910     3909       -1     
Flag Coverage Δ
unit-pull-request 71.35% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/neptune/__init__.py 100.00% <ø> (ø)
src/neptune/common/exceptions.py 62.33% <ø> (ø)
src/neptune/exceptions.py 82.63% <ø> (ø)
src/neptune/integrations/python_logger.py 100.00% <ø> (ø)
src/neptune/internal/init/__init__.py 100.00% <ø> (+9.09%) ⬆️
src/neptune/new/__init__.py 94.11% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@AleksanderWWW AleksanderWWW marked this pull request as ready for review February 13, 2023 13:45
@normandy7
Copy link
Collaborator

For future reference: There should generally be no need to change method to function unless it's a mistake in the first place :) We mostly talk about "methods" in the docs.

@AleksanderWWW AleksanderWWW merged commit 170d69a into dev/1.0.0 Feb 13, 2023
@AleksanderWWW AleksanderWWW deleted the aw/remove_init_func branch February 13, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants