Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove model and version params #1223

Merged
merged 7 commits into from
Feb 15, 2023
Merged

Conversation

AleksanderWWW
Copy link
Contributor

@AleksanderWWW AleksanderWWW commented Feb 14, 2023

Before submitting checklist

  • Did you update the CHANGELOG? (not for test updates, internal changes/refactors or CI/CD setup)
  • Did you asked the docs owner to review all the updated user-facing interfaces?

@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Base: 79.26% // Head: 71.30% // Decreases project coverage by -7.96% ⚠️

Coverage data is based on head (67f962d) compared to base (61730b8).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1223      +/-   ##
==========================================
- Coverage   79.26%   71.30%   -7.96%     
==========================================
  Files         284      284              
  Lines       13632    13628       -4     
==========================================
- Hits        10805     9718    -1087     
- Misses       2827     3910    +1083     
Flag Coverage Δ
e2e ?
unit ?
unit-pull-request 71.30% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/neptune/internal/init/model.py 93.65% <ø> (-4.82%) ⬇️
src/neptune/internal/init/model_version.py 98.36% <ø> (-0.06%) ⬇️
src/neptune/metadata_containers/model.py 95.45% <ø> (ø)
...eptune/common/websockets/reconnecting_websocket.py 27.77% <0.00%> (-50.01%) ⬇️
...tune/common/websockets/websocket_client_adapter.py 34.78% <0.00%> (-50.01%) ⬇️
...neptune/legacy/internal/utils/alpha_integration.py 41.66% <0.00%> (-45.84%) ⬇️
...ternal/threads/hardware_metric_reporting_thread.py 39.13% <0.00%> (-43.48%) ⬇️
...ernal/websockets/reconnecting_websocket_factory.py 57.14% <0.00%> (-42.86%) ⬇️
...tune/legacy/internal/streams/stdstream_uploader.py 46.87% <0.00%> (-40.63%) ⬇️
src/neptune/common/patches/bravado.py 38.88% <0.00%> (-38.89%) ⬇️
... and 93 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@AleksanderWWW AleksanderWWW marked this pull request as ready for review February 14, 2023 14:27
CHANGELOG.md Outdated Show resolved Hide resolved
@AleksanderWWW AleksanderWWW changed the title Aw/remove model param init model Remove model and version params Feb 14, 2023
@AleksanderWWW AleksanderWWW merged commit e58a935 into master Feb 15, 2023
@AleksanderWWW AleksanderWWW deleted the aw/remove_model_param_init_model branch February 15, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants