Change run status to Active / Inactive #1233
Conversation
Codecov ReportBase: 71.66% // Head: 71.29% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1233 +/- ##
==========================================
- Coverage 71.66% 71.29% -0.38%
==========================================
Files 280 281 +1
Lines 13571 13594 +23
==========================================
- Hits 9726 9692 -34
- Misses 3845 3902 +57
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
...eptune/legacy/internal/api_clients/hosted_api_clients/hosted_alpha_leaderboard_api_client.py
Outdated
Show resolved
Hide resolved
shnela
force-pushed
the
jk/run-status
branch
from
223bb25 to
c8c0abe
Compare
| query_items.append( | ||
| NQLQueryAggregate( | ||
| items=[ | ||
| NQLQueryAttribute( | ||
| name="sys/state", | ||
| type=NQLAttributeType.EXPERIMENT_STATE, | ||
| operator=NQLAttributeOperator.EQUALS, | ||
| value=state, | ||
| value=api_state, |
There was a problem hiding this comment.
What about just value=RunState(state).to_api() instead of separate list?
There was a problem hiding this comment.
Good point.
I've implemented it higher and then moved the code here.
| @@ -0,0 +1,45 @@ | |||
| # | |||
There was a problem hiding this comment.
How about moving it directly to metadata_containers_table or to internal subpackage?
No description provided.