Fix fetch_runs_table method for state param usage

CHANGELOG.md

@@ -21,6 +21,7 @@
 - Added exception for unsupported types ([#1229](https://github.com/neptune-ai/neptune-client/pull/1229))
 - Change run status to Active / Inactive ([#1233](https://github.com/neptune-ai/neptune-client/pull/1233))
 - Package renamed from `neptune-client` to `neptune` ([#1225](https://github.com/neptune-ai/neptune-client/pull/1225))
+- Changed return values for run state ([#1253](https://github.com/neptune-ai/neptune-client/pull/1253))
 
 ## neptune-client 0.16.18
 

src/neptune/internal/utils/run_state.py

@@ -27,6 +27,13 @@ class RunState(enum.Enum):
     _api_active = "running"
     _api_inactive = "idle"
 
+    @classmethod
+    def from_string(cls, value: str) -> "RunState":
+        try:
+            return cls(value.capitalize())
+        except ValueError as e:
+            raise NeptuneException(f"Can't map RunState to API: {value}") from e
+
     @staticmethod
     def from_api(value: str) -> "RunState":
         if value == RunState._api_active.value:
@@ -35,3 +42,9 @@ def from_api(value: str) -> "RunState":
             return RunState.inactive
         else:
             raise NeptuneException(f"Unknown RunState: {value}")
+
+    def to_api(self) -> str:
+        if self is RunState.active:
+            return self._api_active.value
+        if self is RunState.inactive:
+            return self._api_inactive.value

src/neptune/metadata_containers/project.py

@@ -42,6 +42,7 @@
 from neptune.internal.operation_processors.operation_processor import OperationProcessor
 from neptune.internal.state import ContainerState
 from neptune.internal.utils import as_list
+from neptune.internal.utils.run_state import RunState
 from neptune.metadata_containers import MetadataContainer
 from neptune.metadata_containers.metadata_containers_table import Table
 from neptune.types.mode import Mode
@@ -131,7 +132,7 @@ def _prepare_nql_query(ids, states, owners, tags):
                             name="sys/state",
                             type=NQLAttributeType.EXPERIMENT_STATE,
                             operator=NQLAttributeOperator.EQUALS,
-                            value=state,
+                            value=RunState.from_string(state).to_api(),
                         )
                         for state in states
                     ],
@@ -261,7 +262,6 @@ def fetch_runs_table(
         tags = as_list("tag", tag)
 
         nql_query = self._prepare_nql_query(ids, states, owners, tags)
-
         return MetadataContainer._fetch_entries(
             self,
             child_type=ContainerType.RUN,

tests/unit/neptune/new/conftest.py

@@ -0,0 +1,9 @@
+import pytest
+
+from neptune import init_project
+from neptune.metadata_containers import Project
+
+
+@pytest.fixture(scope="session")
+def project() -> Project:
+    return init_project(mode="read-only")

tests/unit/neptune/new/test_fetch_runs_table.py

@@ -0,0 +1,17 @@
+import pytest
+
+from neptune.exceptions import NeptuneException
+
+
+@pytest.mark.parametrize("state", ["active", "inactive", "Active", "Inactive", "aCTive", "INacTiVe"])
+def test_fetch_runs_table_is_case_insensitive(state, project):
+    try:
+        project.fetch_runs_table(state=state)
+        assert True
+    except Exception as e:
+        assert False, e
+
+
+def test_fetch_runs_table_raises_correct_exception_if_state_incorrect(project):
+    with pytest.raises(NeptuneException):
+        project.fetch_runs_table(state="some_incorrect_state")