Fix crashing syncing thread when logging big integers #1336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aniezurawski
force-pushed
the
waj/fix-64-bit-crash
branch
from
65e9f08 to
a1a4fcf
Compare
aniezurawski
force-pushed
the
waj/fix-64-bit-crash
branch
from
a1a4fcf to
6178d6a
Compare
aniezurawski
changed the title
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1336 +/- ##
==========================================
- Coverage 79.64% 79.64% -0.01%
==========================================
Files 275 275
Lines 13517 13523 +6
==========================================
+ Hits 10766 10770 +4
- Misses 2751 2753 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
aniezurawski
changed the title
AleksanderWWW
previously approved these changes
May 5, 2023
| @@ -45,5 +53,17 @@ def assign(self, value: typing.Union[IntegerVal, float, int], *, wait: bool = Fa | |||
| if not isinstance(value, IntegerVal): | |||
| value = IntegerVal(value) | |||
|
|
|||
| if value.value > Integer.MAX_32_BIT_INT or value.value < Integer.MIN_32_BIT_INT: | |||
There was a problem hiding this comment.
Slightly more readable syntax:
Integer.MIN_32_BIT_INT < value.value < Integer.MAX_32_BIT_INT
Raalsky
suggested changes
May 8, 2023
Raalsky
previously approved these changes
May 8, 2023
Raalsky
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.