-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow users to pass neptune data directory as env var #1409
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1409 +/- ##
==========================================
- Coverage 79.52% 75.36% -4.16%
==========================================
Files 280 280
Lines 13874 13875 +1
==========================================
- Hits 11033 10457 -576
- Misses 2841 3418 +577
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
@@ -27,6 +25,14 @@ | |||
from neptune.internal.utils.logger import logger | |||
|
|||
|
|||
def get_container_dir(type_dir: str, container_id: UniqueId, container_type: ContainerType) -> str: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This func is basically the clue of this PR. The rest is just adjusting the existing code for its usage
Before submitting checklist