Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow users to pass neptune data directory as env var #1409

Merged
merged 12 commits into from
Aug 8, 2023

Conversation

AleksanderWWW
Copy link
Contributor

Before submitting checklist

  • Did you update the CHANGELOG? (not for test updates, internal changes/refactors or CI/CD setup)
  • Did you ask the docs owner to review all the user-facing changes?

@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -4.16% ⚠️

Comparison is base (d48d235) 79.52% compared to head (b10b98f) 75.36%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1409      +/-   ##
==========================================
- Coverage   79.52%   75.36%   -4.16%     
==========================================
  Files         280      280              
  Lines       13874    13875       +1     
==========================================
- Hits        11033    10457     -576     
- Misses       2841     3418     +577     
Flag Coverage Δ
e2e-management ?
e2e-s3 ?
e2e-s3-gcs ?
e2e-standard ?
macos 72.80% <100.00%> (-6.43%) ⬇️
py3.7 73.10% <100.00%> (-5.87%) ⬇️
py3.9 ?
ubuntu 72.96% <100.00%> (-6.34%) ⬇️
unit 73.10% <100.00%> (-0.62%) ⬇️
windows 72.24% <100.00%> (-7.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
.../operation_processors/async_operation_processor.py 87.16% <100.00%> (-0.18%) ⬇️
...peration_processors/offline_operation_processor.py 92.85% <100.00%> (ø)
...internal/operation_processors/operation_storage.py 94.28% <100.00%> (-2.49%) ⬇️
...l/operation_processors/sync_operation_processor.py 91.89% <100.00%> (-0.22%) ⬇️

... and 59 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AleksanderWWW AleksanderWWW changed the title create .neptune in tmp folder if on AWS lambda allow users to pass neptune data directory as env var Jul 28, 2023
@@ -27,6 +25,14 @@
from neptune.internal.utils.logger import logger


def get_container_dir(type_dir: str, container_id: UniqueId, container_type: ContainerType) -> str:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This func is basically the clue of this PR. The rest is just adjusting the existing code for its usage

@AleksanderWWW AleksanderWWW merged commit b261ae9 into master Aug 8, 2023
@AleksanderWWW AleksanderWWW deleted the aw/aws-lambda-folder branch August 8, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants