Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli and docstrings language review #1465

Merged
merged 11 commits into from
Sep 18, 2023
Merged

cli and docstrings language review #1465

merged 11 commits into from
Sep 18, 2023

Conversation

TytusKalicki
Copy link
Contributor

@TytusKalicki TytusKalicki commented Sep 12, 2023 •
edited by normandy7
Loading

Before submitting checklist

  • Did you update the CHANGELOG? (not for test updates, internal changes/refactors or CI/CD setup)
  • Did you ask the docs owner to review all the user-facing changes?

@codecov
Copy link

codecov bot commented Sep 12, 2023 •
edited
Loading

Codecov Report

Patch coverage is 50.00% of modified lines.

Files Changed Coverage
src/neptune/cli/__main__.py 0.00%
src/neptune/cli/clear.py ø
src/neptune/cli/commands.py ø
src/neptune/cli/status.py ø
src/neptune/cli/utils.py ø
src/neptune/common/exceptions.py ø
src/neptune/common/utils.py ø
src/neptune/exceptions.py ø
src/neptune/version.py ø
src/neptune/handler.py 60.00%

📢 Thoughts on this report? Let us know!.

normandy7
normandy7 reviewed Sep 12, 2023
View reviewed changes
Copy link
Collaborator

@normandy7 normandy7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of comments.

src/neptune/__init__.py Show resolved Hide resolved
src/neptune/cli/commands.py Outdated Show resolved Hide resolved
src/neptune/cli/commands.py Outdated Show resolved Hide resolved
normandy7
normandy7 reviewed Sep 12, 2023
View reviewed changes
src/neptune/handler.py Outdated Show resolved Hide resolved
Raalsky
Raalsky previously approved these changes Sep 12, 2023
View reviewed changes
@Raalsky
Copy link
Contributor

Raalsky commented Sep 12, 2023

A kindly reminder about updating the CHANGELOG 😉

normandy7
normandy7 requested changes Sep 14, 2023
View reviewed changes
src/neptune/handler.py Outdated Show resolved Hide resolved
src/neptune/handler.py Outdated Show resolved Hide resolved
src/neptune/handler.py Outdated Show resolved Hide resolved
src/neptune/handler.py Outdated Show resolved Hide resolved
src/neptune/handler.py Outdated Show resolved Hide resolved
src/neptune/handler.py Outdated Show resolved Hide resolved
normandy7
normandy7 reviewed Sep 18, 2023
View reviewed changes
src/neptune/handler.py Outdated Show resolved Hide resolved
normandy7
normandy7 reviewed Sep 18, 2023
View reviewed changes
src/neptune/handler.py Outdated Show resolved Hide resolved
normandy7
normandy7 reviewed Sep 18, 2023
View reviewed changes
src/neptune/handler.py Outdated Show resolved Hide resolved
normandy7
normandy7 previously approved these changes Sep 18, 2023
View reviewed changes
Raalsky
Raalsky reviewed Sep 18, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@normandy7 normandy7 merged commit ee0f099 into master Sep 18, 2023
@normandy7 normandy7 deleted the cli-review branch September 18, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@normandy7 normandy7 normandy7 approved these changes

@Raalsky Raalsky Raalsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TytusKalicki @Raalsky @normandy7