Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flag to disable deletion of local parent folder #1511

Merged
merged 8 commits into from
Oct 11, 2023
Merged

flag to disable deletion of local parent folder #1511

merged 8 commits into from
Oct 11, 2023

Conversation

artsiomtserashkovich
Copy link
Contributor

@artsiomtserashkovich artsiomtserashkovich commented Oct 11, 2023 •
edited by Raalsky
Loading

Before submitting checklist

  • Did you update the CHANGELOG? (not for test updates, internal changes/refactors or CI/CD setup)
  • Did you ask the docs owner to review all the user-facing changes?

Raalsky
Raalsky reviewed Oct 11, 2023
View reviewed changes
src/neptune/internal/operation_processors/operation_storage.py Show resolved Hide resolved
src/neptune/internal/disk_queue.py Outdated Show resolved Hide resolved
src/neptune/envs.py Outdated Show resolved Hide resolved
@artsiomtserashkovich artsiomtserashkovich changed the title NEPTUNE_DISABLE_LOCALFILES_CLEANUP flag flag to disable deletion of local parent folder Oct 11, 2023
@artsiomtserashkovich artsiomtserashkovich marked this pull request as ready for review October 11, 2023 14:22
@codecov
Copy link

codecov bot commented Oct 11, 2023 •
edited
Loading

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Files Coverage Δ
src/neptune/envs.py 100.00% <100.00%> (ø)
src/neptune/internal/disk_queue.py 95.18% <100.00%> (+2.07%) ⬆️
...internal/operation_processors/operation_storage.py 100.00% <100.00%> (ø)
src/neptune/internal/utils/files.py 86.66% <86.66%> (ø)

... and 110 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

Raalsky
Raalsky reviewed Oct 11, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
src/neptune/internal/disk_queue.py Outdated Show resolved Hide resolved
@Raalsky Raalsky merged commit 3fc9679 into master Oct 11, 2023
@Raalsky Raalsky deleted the at/disable_clear_async_folder_flag branch October 11, 2023 15:44
@SiddhantSadangi SiddhantSadangi linked an issue Oct 20, 2023 that may be closed by this pull request
ZD766: I/O operation on closed file. #1452
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Raalsky Raalsky Raalsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ZD766: I/O operation on closed file.
2 participants
@artsiomtserashkovich @Raalsky