Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added get_workspace_status method to management API #1662

Merged
merged 12 commits into from
Feb 29, 2024
Merged

Added get_workspace_status method to management API #1662

merged 12 commits into from
Feb 29, 2024

Conversation

Raalsky
Copy link
Contributor

@Raalsky Raalsky commented Feb 26, 2024 •
edited
Loading

Before submitting checklist

  • Did you update the CHANGELOG? (not for test updates, internal changes/refactors or CI/CD setup)
  • Did you ask the docs owner to review all the user-facing changes?

@Raalsky
Copy link
Contributor Author

Raalsky commented Feb 26, 2024

E2E https://github.com/neptune-ai/neptune-client/actions/runs/8046925649

@codecov Codecov
Copy link

codecov bot commented Feb 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 4.34783% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 74.46%. Comparing base (d1061cc) to head (cde9e95).

Files Patch % Lines
src/neptune/management/internal/api.py 4.34% 22 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1662      +/-   ##
==========================================
- Coverage   80.41%   74.46%   -5.96%     
==========================================
  Files         302      302              
  Lines       15461    15173     -288     
==========================================
- Hits        12433    11298    -1135     
- Misses       3028     3875     +847
Flag Coverage Δ
e2e ?
e2e-management ?
e2e-s3 ?
e2e-s3-gcs ?
e2e-standard ?
macos 74.24% <4.34%> (-5.95%) ⬇️
py3.10 ?
py3.7 74.57% <4.34%> (-5.34%) ⬇️
py3.7.16 ?
py3.8 ?
py3.9 ?
ubuntu 74.43% <4.34%> (-5.74%) ⬇️
unit 74.57% <4.34%> (-0.65%) ⬇️
windows 73.48% <4.34%> (-6.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

parthpankajtiwary
parthpankajtiwary previously approved these changes Feb 26, 2024
View reviewed changes
Copy link

@parthpankajtiwary parthpankajtiwary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🙂

normandy7
normandy7 requested changes Feb 26, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
src/neptune/management/__init__.py Outdated Show resolved Hide resolved
src/neptune/management/internal/api.py Outdated Show resolved Hide resolved
src/neptune/management/internal/api.py Outdated Show resolved Hide resolved
src/neptune/management/internal/api.py Outdated Show resolved Hide resolved
Raalsky and others added 4 commits February 26, 2024 15:20
@Raalsky @normandy7
Update CHANGELOG.md
ae21290 
Co-authored-by: Sabine <sabine.nyholm@neptune.ai>
@Raalsky @normandy7
Update src/neptune/management/__init__.py
80ff4f6 
Co-authored-by: Sabine <sabine.nyholm@neptune.ai>
@Raalsky @normandy7
Update src/neptune/management/internal/api.py
ea795c0 
Co-authored-by: Sabine <sabine.nyholm@neptune.ai>
@Raalsky @normandy7
Update src/neptune/management/internal/api.py
e236a3e 
Co-authored-by: Sabine <sabine.nyholm@neptune.ai>
szysad
szysad previously approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@szysad szysad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Is this just enabling new backed endpoint in client?

@Raalsky
Copy link
Contributor Author

Raalsky commented Feb 27, 2024

Is this just enabling new backed endpoint in client?

Exactly 😉

@Raalsky @normandy7
Update src/neptune/management/internal/api.py
365e945 
Co-authored-by: Sabine <sabine.nyholm@neptune.ai>
@Raalsky Raalsky requested a review from normandy7 February 29, 2024 07:30
normandy7
normandy7 previously approved these changes Feb 29, 2024
View reviewed changes
@Raalsky Raalsky merged commit 3180c16 into master Feb 29, 2024
4 checks passed
@Raalsky Raalsky deleted the rj/storage-info branch February 29, 2024 10:05
AleksanderWWW pushed a commit that referenced this pull request Feb 29, 2024
@Raalsky @normandy7 @AleksanderWWW
Added get_workspace_status method to management API (#1662)
511dbba 
Co-authored-by: Sabine <sabine.nyholm@neptune.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@normandy7 normandy7 normandy7 approved these changes

@szysad szysad szysad left review comments

@parthpankajtiwary parthpankajtiwary parthpankajtiwary left review comments

@AleksanderWWW AleksanderWWW Awaiting requested review from AleksanderWWW

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Raalsky @parthpankajtiwary @normandy7 @szysad