Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Series values fetching reworked with protocol buffer support #1744

Merged
merged 8 commits into from
Apr 17, 2024

Conversation

Raalsky
Copy link
Contributor

@Raalsky Raalsky commented Apr 16, 2024

Before submitting checklist

  • Did you update the CHANGELOG? (not for test updates, internal changes/refactors or CI/CD setup)
  • Did you ask the docs owner to review all the user-facing changes?

@Raalsky Raalsky force-pushed the rj/series-fetching-reworked branch from 77c8761 to 38a6819 Compare April 16, 2024 12:31
Copy link

codecov bot commented Apr 16, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 76.91%. Comparing base (b6a168f) to head (b623f33).
Report is 3 commits behind head on master.

Files Patch % Lines
...eptune/internal/backends/hosted_neptune_backend.py 12.50% 7 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1744   +/-   ##
=======================================
  Coverage   76.91%   76.91%           
=======================================
  Files         244      245    +1     
  Lines       13016    13029   +13     
=======================================
+ Hits        10011    10021   +10     
- Misses       3005     3008    +3     
Flag Coverage Δ
e2e 65.26% <30.95%> (+0.08%) ⬆️
e2e-management 55.95% <30.95%> (+0.08%) ⬆️
e2e-s3 53.08% <30.95%> (+0.10%) ⬆️
e2e-s3-gcs 53.08% <30.95%> (+0.10%) ⬆️
e2e-standard 65.25% <30.95%> (+0.14%) ⬆️
macos 76.78% <83.33%> (-0.07%) ⬇️
py3.10 ?
py3.11 ?
py3.12 65.37% <30.95%> (-11.80%) ⬇️
py3.7 76.30% <83.33%> (+0.08%) ⬆️
py3.7.16 64.38% <30.95%> (-11.71%) ⬇️
py3.8 ?
py3.9 ?
ubuntu 76.85% <83.33%> (+0.03%) ⬆️
unit 73.16% <83.33%> (-0.66%) ⬇️
windows 76.54% <83.33%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Raalsky Raalsky changed the title Draft: Reworked series fetching Series values fetching reworked with protocol buffer support Apr 16, 2024
@Raalsky
Copy link
Contributor Author

Raalsky commented Apr 16, 2024

Copy link
Contributor

@szysad szysad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀🚀

@Raalsky Raalsky merged commit f495158 into master Apr 17, 2024
29 checks passed
@Raalsky Raalsky deleted the rj/series-fetching-reworked branch April 17, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants