Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dependabot for neptune-client package #1750

Merged
merged 3 commits into from
Apr 18, 2024
Merged

Conversation

Raalsky
Copy link
Contributor

@Raalsky Raalsky commented Apr 16, 2024

Before submitting checklist

  • Did you update the CHANGELOG? (not for test updates, internal changes/refactors or CI/CD setup)
  • Did you ask the docs owner to review all the user-facing changes?

Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.03%. Comparing base (9679a2d) to head (992d6c8).

Additional details and impacted files
@@             Coverage Diff             @@
##           dev/1.x    #1750      +/-   ##
===========================================
+ Coverage    72.44%   75.03%   +2.59%     
===========================================
  Files          304      304              
  Lines        15358    15050     -308     
===========================================
+ Hits         11126    11293     +167     
+ Misses        4232     3757     -475     
Flag Coverage Δ
e2e ?
e2e-management ?
e2e-s3 ?
e2e-s3-gcs ?
e2e-standard ?
macos 74.76% <ø> (+2.57%) ⬆️
py3.12 ?
py3.7 75.03% <ø> (+3.28%) ⬆️
py3.7.16 ?
ubuntu 74.90% <ø> (+2.62%) ⬆️
unit 75.03% <ø> (?)
windows 73.95% <ø> (+1.99%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


# Old `neptune-client` package
- package-ecosystem: pip
directory: ".github/"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the directory .github here and in the new neptune it's /?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's where we're storing the package definition of neptune-client :D. Take a look at release workflow 😉

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently Dependabot is looking for only neptune package (probably) as only our pyproject.toml is detected from the root directory. We would like to take into account neptune-client as well that was stored in .github directory.

@Raalsky Raalsky merged commit 448759d into dev/1.x Apr 18, 2024
4 checks passed
@Raalsky Raalsky deleted the rj/dependabot-dev-1-x branch April 18, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants