-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make handling of sys/name dependend on config flag #1777
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev/1.x #1777 +/- ##
===========================================
- Coverage 81.21% 75.61% -5.60%
===========================================
Files 304 304
Lines 15365 15365
===========================================
- Hits 12478 11618 -860
- Misses 2887 3747 +860
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Manual tests:
Neither of these scenarios raises an exception |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
5eadb4f
Before submitting checklist