Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make handling of sys/name dependend on config flag #1777

Merged
merged 4 commits into from
May 15, 2024

Conversation

AleksanderWWW
Copy link
Contributor

@AleksanderWWW AleksanderWWW commented May 15, 2024

Before submitting checklist

  • Did you update the CHANGELOG? (not for test updates, internal changes/refactors or CI/CD setup)
  • Did you ask the docs owner to review all the user-facing changes?

Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.61%. Comparing base (b3311f4) to head (5eadb4f).

Additional details and impacted files
@@             Coverage Diff             @@
##           dev/1.x    #1777      +/-   ##
===========================================
- Coverage    81.21%   75.61%   -5.60%     
===========================================
  Files          304      304              
  Lines        15365    15365              
===========================================
- Hits         12478    11618     -860     
- Misses        2887     3747     +860     
Flag Coverage Δ
e2e ?
e2e-management ?
e2e-s3 ?
e2e-s3-gcs ?
e2e-standard ?
macos 75.28% <100.00%> (-5.65%) ⬇️
py3.10 ?
py3.11 ?
py3.12 ?
py3.7 74.99% <100.00%> (-5.68%) ⬇️
py3.8 75.28% <100.00%> (-5.77%) ⬇️
py3.9 ?
ubuntu 74.86% <100.00%> (-6.17%) ⬇️
unit 75.61% <100.00%> (-0.02%) ⬇️
windows 73.89% <100.00%> (-6.73%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AleksanderWWW
Copy link
Contributor Author

Manual tests:

import neptune


with neptune.Run() as run:
    run.sync()
    print(run["sys/name"].fetch())
  • Current app.neptune.ai - name is set automatically to Untitled
  • If the flag is present - name is None and is handled by the backend ✅

Neither of these scenarios raises an exception

@AleksanderWWW AleksanderWWW marked this pull request as ready for review May 15, 2024 09:09
szysad
szysad previously approved these changes May 15, 2024
Copy link
Contributor

@szysad szysad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AleksanderWWW AleksanderWWW dismissed stale reviews from szysad and SiddhantSadangi via 5eadb4f May 15, 2024 09:34
@AleksanderWWW AleksanderWWW merged commit f9f0b77 into dev/1.x May 15, 2024
4 checks passed
@AleksanderWWW AleksanderWWW deleted the aw/client-config-flag branch May 15, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants