Added **kwargs to upload() and File.as_html() methods
#1881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ile.as_html() methods
SiddhantSadangi
requested review from
PatrykGala and
kgodlewski
as code owners
SiddhantSadangi
changed the title
kwargs to upload() and File.as_html() methods**kwargs to upload() and File.as_html() methods
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev/1.x #1881 +/- ##
===========================================
- Coverage 81.23% 75.59% -5.64%
===========================================
Files 303 303
Lines 15382 15364 -18
===========================================
- Hits 12495 11614 -881
- Misses 2887 3750 +863
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kgodlewski
approved these changes
Oct 29, 2024
|
@kgodlewski - lets wait for @normandy7 to review as there are user-facing changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting checklist
This change lets you pass
include_plotlyjsas a keyword-only argument toupload()andas_html()methods.The default
Truevalue retains current behaviour, while passing"cdn"reduces the size of the uploaded HTML file by ~3MB, but requires an internet connection.Closes (#1870)