Skip to content
This repository has been archived by the owner on Dec 5, 2022. It is now read-only.

Revert "added --user to installs" #17

Merged
merged 10 commits into from
Oct 27, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/neptune-examples.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
name: neptune-examples
on:
push:
paths-ignore:
- 'README.md'
PiotrJander marked this conversation as resolved.
Show resolved Hide resolved
schedule:
- cron: '*/14 3 * * *' # Run once daily at arbitrary time (3:14 AM UTC)
jobs:
Expand Down
24 changes: 13 additions & 11 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -127,14 +127,16 @@ For example:

### Notes

The following files are a temporary fix (leaving old paths for now):
- logging_snippets.ipynb
- Neptune-API-Tour.ipynb
- Organize-ML-experiments.ipynb
- r-integration.ipynb
- Use-Neptune-API-to-log-your-first-experiment.ipynb
- Monitor-ML-runs-live.ipynb
- neptune_test_run.ipynb
- pytorch_lightning-integration.ipynb
- Template.ipynb
- xgboost-integration.ipynb
- The following files are a temporary fix (leaving old paths for now):
- logging_snippets.ipynb
- Neptune-API-Tour.ipynb
- Organize-ML-experiments.ipynb
- r-integration.ipynb
- Use-Neptune-API-to-log-your-first-experiment.ipynb
- Monitor-ML-runs-live.ipynb
- neptune_test_run.ipynb
- pytorch_lightning-integration.ipynb
- Template.ipynb
- xgboost-integration.ipynb
- XGBoost integration (upgraded libs case) is not tested on Win with Python 3.8, as it causes [tkinter error](https://github.com/neptune-ai/neptune-examples/runs/1309037471?check_suite_focus=true).
kamil-kaczmarek marked this conversation as resolved.
Show resolved Hide resolved
- "Neptune-API-Tour" (product-tours) is not tested on Windows, because unable to install Tensorflow on a Windows CI server ([error msg](https://github.com/neptune-ai/neptune-examples/pull/17/checks?check_run_id=1308563484#step:10:328)).
4 changes: 3 additions & 1 deletion ci/build.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
import os
import re

from glob import glob
from pathlib import Path
import re
from subprocess import call


Expand Down
23 changes: 23 additions & 0 deletions ci/test_examples.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
import os
import sys

from glob import glob
from subprocess import check_call

Expand All @@ -6,6 +9,26 @@
test_files = glob('**/tests/*.py', recursive=True)

excluded_files = []
if os.name == 'nt': # if OS is Windows
# Excluding because unable to install Tensorflow on a Windows CI server with
#
# ERROR: Could not install packages due to an EnvironmentError: [WinError 5] Access is denied: 'c:\\hostedtoolcache\\windows\\python\\3.6.8\\x64\\lib\\site-packages\\~umpy\\.libs\\libopenblas.NOIJJG62EMASZI6NYURL6JBKM4EVBGM7.gfortran-win_amd64.dll'
# Consider using the `--user` option or check the permissions.
excluded_files.extend(glob('product-tours\\how-it-works\\tests\\*.py', recursive=True))
kamil-kaczmarek marked this conversation as resolved.
Show resolved Hide resolved

# if OS is Windows and Python is 3.8
if os.name == 'nt' and sys.version_info.major == 3 and sys.version_info.minor == 8:
# Excluding because on a Windows CI server with Python 3.8, tkinter error occurs.
#
# Traceback (most recent call last):
#
# File "c:\hostedtoolcache\windows\python\3.8.6\x64\lib\tkinter\__init__.py", line 4014, in __del__
#
# self.tk.call('image', 'delete', self.name)
#
# RuntimeError: main thread is not in main loop
excluded_files.append('integrations\\xgboost\\tests\\Neptune-XGBoost_upgraded_libs.py')
kamil-kaczmarek marked this conversation as resolved.
Show resolved Hide resolved


@pytest.mark.parametrize("filename", [f for f in test_files if f not in excluded_files])
def test_examples(filename):
Expand Down
6 changes: 3 additions & 3 deletions integrations/xgboost/Neptune-XGBoost.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@
},
"outputs": [],
"source": [
"! pip install --user neptune-client==0.4.124 neptune-contrib[monitoring]==0.24.3 xgboost==1.2.0 pandas==1.0.5 scikit-learn==0.23.2"
"! pip install neptune-client==0.4.124 neptune-contrib[monitoring]==0.24.3 xgboost==1.2.0 pandas==1.0.5 scikit-learn==0.23.2"
]
},
{
Expand All @@ -89,7 +89,7 @@
},
"outputs": [],
"source": [
"! pip install --user --upgrade neptune-client neptune-contrib[monitoring] xgboost pandas scikit-learn"
"! pip install neptune-client neptune-contrib[monitoring] xgboost pandas scikit-learn --upgrade"
]
},
{
Expand Down Expand Up @@ -388,7 +388,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.7.7"
"version": "3.6.9"
},
"neptune": {
"notebookId": "d9ac48b4-401d-4e45-a04c-c458ab10fa29"
Expand Down
4 changes: 2 additions & 2 deletions integrations/xgboost/docs/Neptune-XGBoost.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
},
"outputs": [],
"source": [
"! pip install --user neptune-client==0.4.124 neptune-contrib[monitoring]==0.24.3 xgboost==1.2.0 pandas==1.0.5 scikit-learn==0.23.2"
"! pip install neptune-client==0.4.124 neptune-contrib[monitoring]==0.24.3 xgboost==1.2.0 pandas==1.0.5 scikit-learn==0.23.2"
]
},
{
Expand Down Expand Up @@ -296,7 +296,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.7.7"
"version": "3.6.9"
},
"neptune": {
"notebookId": "d9ac48b4-401d-4e45-a04c-c458ab10fa29"
Expand Down
4 changes: 2 additions & 2 deletions integrations/xgboost/showcase/Neptune-XGBoost.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@
},
"outputs": [],
"source": [
"! pip install --user neptune-client==0.4.124 neptune-contrib[monitoring]==0.24.3 xgboost==1.2.0 pandas==1.0.5 scikit-learn==0.23.2"
"! pip install neptune-client==0.4.124 neptune-contrib[monitoring]==0.24.3 xgboost==1.2.0 pandas==1.0.5 scikit-learn==0.23.2"
]
},
{
Expand Down Expand Up @@ -374,7 +374,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.7.7"
"version": "3.6.9"
},
"neptune": {
"notebookId": "d9ac48b4-401d-4e45-a04c-c458ab10fa29"
Expand Down
2 changes: 1 addition & 1 deletion integrations/xgboost/tests/Neptune-XGBoost.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

## Install dependencies

get_ipython().system(' pip install --user neptune-client==0.4.124 neptune-contrib[monitoring]==0.24.3 xgboost==1.2.0 pandas==1.0.5 scikit-learn==0.23.2')
get_ipython().system(' pip install neptune-client==0.4.124 neptune-contrib[monitoring]==0.24.3 xgboost==1.2.0 pandas==1.0.5 scikit-learn==0.23.2')

import neptune
import pandas as pd
Expand Down
4 changes: 2 additions & 2 deletions integrations/xgboost/tests/Neptune-XGBoost_upgraded_libs.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@

## Install dependencies

get_ipython().system(' pip install --user neptune-client==0.4.124 neptune-contrib[monitoring]==0.24.3 xgboost==1.2.0 pandas==1.0.5 scikit-learn==0.23.2')
get_ipython().system(' pip install neptune-client==0.4.124 neptune-contrib[monitoring]==0.24.3 xgboost==1.2.0 pandas==1.0.5 scikit-learn==0.23.2')

get_ipython().system(' pip install --user --upgrade neptune-client neptune-contrib[monitoring] xgboost pandas scikit-learn')
get_ipython().system(' pip install neptune-client neptune-contrib[monitoring] xgboost pandas scikit-learn --upgrade')

import neptune
import pandas as pd
Expand Down