Skip to content

Commit

Permalink
Getting rid of pylint related annotations and configurations (#43)
Browse files Browse the repository at this point in the history
  • Loading branch information
Raalsky authored Nov 3, 2022
1 parent 5210191 commit b84cf98
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 309 deletions.
2 changes: 1 addition & 1 deletion .github/actions/e2e/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,5 +27,5 @@ runs:

- name: Run tests
working-directory: ${{ inputs.working_directory }}
run: py.test
run: pytest
shell: bash
11 changes: 7 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -1,19 +1,22 @@
name: neptune-fastai
on: [push]
jobs:
lint:
pre-commit:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2

- uses: actions/setup-python@v2
with:
python-version: 3.9

- name: Install dependencies
run: |
pip install -e .[dev]
- name: Lint
run: |
python -m pylint -j 0 -f parseable neptune_fastai tests
- name: pre-commit run
uses: pre-commit/action@v3.0.0

test:
runs-on: ${{ matrix.os }}
strategy:
Expand Down
299 changes: 0 additions & 299 deletions pylintrc

This file was deleted.

2 changes: 0 additions & 2 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@ def main():
all_deps += extras[group_name]
extras["all"] = all_deps
extras["dev"] = [
"pylint==2.9.6",
"pylintfileheader",
"pytest>=5.0",
"pytest-tap==3.2",
"pytest-cov==2.10.1",
Expand Down
2 changes: 0 additions & 2 deletions src/neptune_fastai/_version.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
# pylint: skip-file

# This file helps to compute a version number in source trees obtained from
# git-archive tarball (such as those provided by githubs download-from-tag
# feature). Distribution tarballs (built by setup.py sdist) and build
Expand Down
2 changes: 1 addition & 1 deletion src/neptune_fastai/impl/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@


class NeptuneCallback(Callback):
# pylint: disable=trailing-whitespace
"""Neptune callback for logging metadata during fastai training loop
See guide with example in the `Neptune-fastai docs`_.
Expand Down Expand Up @@ -170,6 +169,7 @@ class NeptuneCallback(Callback):
https://github.com/neptune-ai/examples/tree/main/integrations-and-supported-tools/fastai/scripts
"""

order = SaveModelCallback.order + 1

def __init__(
Expand Down

0 comments on commit b84cf98

Please sign in to comment.