Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing docstrings #11

Merged
merged 3 commits into from
Aug 21, 2023
Merged

Add missing docstrings #11

merged 3 commits into from
Aug 21, 2023

Conversation

normandy7
Copy link
Contributor

Adds docstrings for log_model() and log_checkpoint().

@normandy7 normandy7 requested a review from kshitij12345 August 16, 2023 08:01
@@ -184,6 +184,23 @@ def base_namespace(self):
return self._base_namespace

def log_model(self, model_name: Optional[str] = None):
"""Uploads the model to Neptune, into a namespace called "model" inside the run.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we mention that model will be under base_namespace?

@normandy7 normandy7 requested a review from kshitij12345 August 16, 2023 11:28
@kshitij12345 kshitij12345 merged commit c4cee0a into master Aug 21, 2023
@kshitij12345 kshitij12345 deleted the sn/add-docstrings branch August 21, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants