Default statblock overwrites morph instance

[eaton]

eldrich.module has a snippet of code to auto-populate a morph instance with the morph's defaults when it's saved without values. BUT. When saved via IEF, the entity instance doesn't seem to HAVE any values when hook_entity_presave fires. In particular, $field->isEmpty() always returns true, ensuring values are always overwritten.

It's a bad scene, man.

[eaton]

More accurately, the StatBlock field doesn't seem to preserve its data between Inline Entity Form updates — the overwriting was just a symptom if it always being empty after an (attempted) save. Other fields, including custom ones like SkillReference, don't have the problem. And StatBlocks don't have the problem when they're not inside of an Inline Entity Form.

[eaton]

It definitely looks like an interaction between Inline Entity Form, StatBlock, and (potentially) Eck entities. Haven't had time to trace it all the way through the call stack and figure out where the ball is being dropped, but it happens with Muses as well.

In the short term, I've replaced Inline Entity Form for Statblock-Possessing Eck entities with EntityBrowser, which might actually be a little cleaner presentationally but is also ass on mobile, so we'll see how it goes.