Add missing properties of User #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pietbrauer
requested changes
Sep 8, 2020
Co-authored-by: Piet Brauer <piet.brauer@me.com>
pietbrauer
reviewed
Sep 8, 2020
| @@ -22,7 +22,7 @@ | |||
| "location": "Hamburg", | |||
| "email": null, | |||
| "hireable": true, | |||
| "bio": null, | |||
| "bio": "Tweeting about iOS and Drumming", | |||
There was a problem hiding this comment.
Haha very humbled, wasn't aware it's my user in the stubs 😆
pietbrauer
approved these changes
Sep 10, 2020
|
Thanks again for your contribution! |
tngranados
pushed a commit
to tngranados/octokit.swift
that referenced
this pull request
Jul 13, 2022
Add missing properties of User
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added some properties that were missing in the
Usermodel.I also added a
Planmodel, which can be returned when you retrieve a user.As far as I know there is no direct API to request plans.
Tests added for
Planand on the unit test on theuser_me.jsonfile.