Import SwiftFormat #117
Closed
Import SwiftFormat #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxDesiatov
reviewed
Dec 18, 2020
.swiftformat
Outdated
| --exclude Tests/LinuxMain.swift,Package.swift | ||
|
|
||
| # format options | ||
| --swiftversion 4.2 |
There was a problem hiding this comment.
Does 4.0 work here? Our Package.swift specifies 4.0
There was a problem hiding this comment.
I'm not sure but I think it will work.
I tried adding matrix to run with Swift 4.0 on Travis🙂
There was a problem hiding this comment.
CI failed on 4.0 and 4.1.
It seems to be required 4.2 on RequestKit🤔
MaxDesiatov
previously approved these changes
Dec 18, 2020
417-72KI
commented
Jan 18, 2021
| @@ -1,4 +1,4 @@ | |||
| // swift-tools-version:4.0 | |||
| // swift-tools-version:4.2 | |||
There was a problem hiding this comment.
Match to RequestKit
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some discussions about formatting (e.g. #116 (comment))
I add SwiftFormat via Mint, and draft configuration.