Fixed issue of nil htmlURL #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…correct mapping from the JSON received
|
Thanks a lot! |
tngranados
pushed a commit
to tngranados/octokit.swift
that referenced
this pull request
Jul 13, 2022
…-url-on-pull-request Fixed issue of nil htmlURL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The htmlURL of a pull request was always nil due to the incorrect mapping of the
Codableconformance of thePullRequestobject.The JSON response always returned the attribute as
html_url, but this was never mapped in thePullRequestobject.