-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add methods to get and create labels #80
Add methods to get and create labels #80
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, thanks for the PR!
Pretty much fine with it but Travis Builds on all platforms have a hard time finding stringByAddingPercentEncodingForRFC3986
could you look into it?
827424b
to
1c509fb
Compare
1c509fb
to
aa060cb
Compare
Whoops, I left a couple things out when cleaning up the commit history. Force-pushed, should be good now. |
Nice, thanks! |
Add methods to get and create labels
This extends
Octokit
with three methods to fetch and create labels..label
to get a single label,.labels
to get all labels in a repo (paginated), and.postLabel
to create a new label in a repo.I've also added test coverage for all three, along with a test for parsing
Label
from JSON.I copied the structure and style based off
Issue
, so everything should be fairly consistent with the existing code, give or take some naming for theLabelRouter
cases.