Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass boolean tensor instead of the occlusion one. #123

Merged
merged 1 commit into from
Nov 26, 2022
Merged

Pass boolean tensor instead of the occlusion one. #123

merged 1 commit into from
Nov 26, 2022

Conversation

thomasw21
Copy link
Contributor

@thomasw21 thomasw21 commented Nov 23, 2022 •
edited
Loading

Not sure what's the purpose of the binary if it's not supposed to be used during query.

@thomasw21 thomasw21 changed the title Pass boolean tensor instead of the occlusion once. Pass boolean tensor instead of the occlusion one. Nov 23, 2022
@liruilong940607
Copy link
Collaborator

Yeah this makes more sense. The query_occ was a function I used in some side experiments, where I need to query the actually cached value in the occupancy grid. But I agree it is more reasonable to return the values in the binary, as a function of the occupancy grid.

@liruilong940607 liruilong940607 merged commit fe75cb8 into nerfstudio-project:master Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomasw21 @liruilong940607