Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typing errors #16

Merged
merged 2 commits into from
Sep 16, 2022
Merged

Fix typing errors #16

merged 2 commits into from
Sep 16, 2022

Conversation

tancik
Copy link
Collaborator

@tancik tancik commented Sep 16, 2022 •
edited
Loading

Fix typing in core library

liruilong940607
liruilong940607 approved these changes Sep 16, 2022
View reviewed changes
Copy link
Collaborator

@liruilong940607 liruilong940607 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the typings! If there is no difference between these two, maybe we want to keep the Tuple[int, int, int] over List[int], which is more explicit on the "shape" of the input argument.

nerfacc/utils.py Show resolved Hide resolved
nerfacc/volumetric_rendering.py Show resolved Hide resolved
nerfacc/occupancy_field.py Show resolved Hide resolved
@tancik
Copy link
Collaborator Author

tancik commented Sep 16, 2022

Keeping as List[int] because occupancy grid support 2d or 3d. May be worth adding more strict types later.

@tancik tancik merged commit 7995c54 into master Sep 16, 2022
@tancik tancik deleted the tancik/fix_typing_errors branch September 16, 2022 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liruilong940607 liruilong940607 liruilong940607 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tancik @liruilong940607