Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the link to train_mlp_nerf #168

Merged
merged 2 commits into from
Feb 25, 2023

Conversation

97littleleaf11
Copy link
Contributor

The extra : leads to an error page. I also changed the link to the file directly.

@liruilong940607
Copy link
Collaborator

Oh thanks. The github link with a specific commit is intentional to keep track of the performance reported on the web. I think changing the link to the file directly makes sense but would be nice to keep the commit in the link

@liruilong940607
Copy link
Collaborator

LGTM!

@liruilong940607 liruilong940607 merged commit 15330b4 into nerfstudio-project:master Feb 25, 2023
@97littleleaf11 97littleleaf11 deleted the patch-1 branch February 25, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants