Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates on examples #174

Merged
merged 6 commits into from
Mar 9, 2023
Merged

Updates on examples #174

merged 6 commits into from
Mar 9, 2023

Conversation

97littleleaf11
Copy link
Contributor

This PR does some minor fixes to the examples:

  • Move the to(device) commands into dataloader
  • Remove redundance check of steps > 0
  • Add a --data_root config and remove the hard-encoded path

@liruilong940607
Copy link
Collaborator

Hey thanks for cleaning them up!

@liruilong940607 liruilong940607 merged commit 82fd69c into nerfstudio-project:master Mar 9, 2023
@97littleleaf11 97littleleaf11 deleted the updates-on-examples branch March 9, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@97littleleaf11 @liruilong940607