-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include a test mode rendering function for Instant NGP in the examples #217
Conversation
8f7f635
to
80b3634
Compare
Thanks Linyou! Do you want to merge this PR in its current state or also adding the usage of this test mode function in the script? I’m happy with both options. Let me know when you done with this PR and want it to be merged. |
Hi, @liruilong940607! Are you suggesting adding an option to the training script that allows switching between train and test modes? If yes, I think the test mode function should be a default option, just like its current state. Since it's closer to the original implementation and faster. |
Oh sorry somehow I missed the change you made to the training script. Changing it to default is reasonable, but in this case we need to carefully verify the metrics do not get affected noticeably comparing to the numbers on the website. -- We don't want future users get inconsistent metrics between the code and the website. I'm happy to test it out in the weekend. But if you already have those numbers (PSNR & Test Time Diff) would be nice to mark them in this PR for future reference. |
Hi, @liruilong940607. This is what I got using an RTX3090 GPU:
NeRF SyntheticTest Mode Rendering:
Train Mode Rendering:
NeRF 360:Test Mode Rendering
Train Mode Rendering
Please note that the |
Awesome thanks for providing those numbers!! This looks great!! I'm gonna merge this PR then. Seems like the website do not need to update as the PSNR basically stays the same. Very cool PR! |
No description provided.