Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support python 3.7 #77

Merged
merged 2 commits into from
Oct 18, 2022
Merged

Support python 3.7 #77

merged 2 commits into from
Oct 18, 2022

Conversation

tancik
Copy link
Collaborator

@tancik tancik commented Oct 18, 2022

We aren't using any functionality that requires 3.8 so might as well also support 3.7.

Copy link
Collaborator

@liruilong940607 liruilong940607 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The importlib.metadata was the only thing that prevents me from setting it to 3.7. Does importlib_metadata need to be installed explicitly? If so is there a way to add it to the pyproject.yaml for python < 3.8?

@tancik tancik merged commit 934f5e9 into master Oct 18, 2022
@tancik tancik deleted the tancik/py37 branch October 18, 2022 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants