TDataset Generic in ParallelDataManager

[fortmeier]

Hi everyone, I starting to get into nerfstudio and encountered something I do not fully understand.

What I am trying to achieve is using the ParallelDataManager, but with another InputDataset.

In the ParallelDataManager, there is this line

nerfstudio/nerfstudio/data/datamanagers/parallel_datamanager.py

Line 144 in 69ed6d4

self.dataset_type: Type[TDataset] = kwargs.get("_dataset_type", getattr(TDataset, "__default__"))

My understanding of generics is limited, but it looks like self.dataset_type is either set by the _dataset_type or is set to the default of TDataset (InputDataset). Other datamanagers behave differently, for example VanillaDataManager uses a method for it:

https://github.com/nerfstudio-project/nerfstudio/blob/69ed6d40935ced2a295702423dac8c0020e3a7d1/nerfstudio/data/datamanagers/base_datamanager.py#L429C1-L452C23

Is this intentional?

Thanks.

[hturki]

#2884