add viewer.local config property when viewing local instance #1358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If running local server instance, avoid using relays to communicate with the viewer.
tancik
reviewed
Feb 6, 2023
There was a problem hiding this comment.
I think this in practice does the exact same thing as --viewer.skip-openrelay
When RTCPeerConnection doesn't receive an input, I believe it falls back to this default which is what we use.
|
It's not quite the same actually, for example if you try in Airplane Mode, you can't connect to the Google server. |
|
Hmm, I guess I don't understand their code well enough. I thought it uses |
Yes
So it's interesting. This does work for me, presumably because it fails to find/connect to the Google server and then gives up. But if the point is to avoid even trying to touch the Google server, then you want the behavior of local and not skip-openrelay. |
yimingzhou1
added a commit
to parallelsystems/nerfstudio
that referenced
this pull request
Feb 7, 2023
* Fix normals visualization (nerfstudio-project#1341) * Fix depth-supervised nerf when using z-buffer depth. (nerfstudio-project#1340) * fix z buffer depth * remove script * Create shaders (nerfstudio-project#1344) * New config parameter --viewer.codec defaults to VP8, but allows H264 (nerfstudio-project#1343) * New config parameter --viewer.codec defaults to H264 rather than VP8 * make quantize clearer * change codec to Literal default is VP8 due to libx264 log spam, see nerfstudio-project#1343 (comment) * isort * pylint, including python 3.7 compatibility * double-quote filenames in process-data commands so that on Windows, paths with spaces don't fail (nerfstudio-project#1347) * double-quote filenames in commands so that on Windows, paths with spaces don't fail * reformatting by black * Improve viewer colormap choices (nerfstudio-project#1348) * Consistent naming for depth maps in Polycam (nerfstudio-project#1352) * Handle uncalibrated Metashape sensor (nerfstudio-project#1359) This fix allows loading Metashape XML files which contain an additional uncalibrated sensor. Metashape XML format keeps unmatched images but assignes a dummy sensor to them. The sensor has no calibration data. Co-authored-by: gilureta <gilureta@amazon.com> * add viewer.local config property when viewing local instance (nerfstudio-project#1358) If running local server instance, avoid using relays to communicate with the viewer. * Allow methods configs to be discovered from external packages. (nerfstudio-project#1357) * Allow method_config to be registered from external packages * Add license * Add MethodSpecification class + fix linter errors --------- * Trace Stable Diffusion (nerfstudio-project#1362) * Trace Stable Diffusion * pylint Co-authored by Terrance Wang * Fix ns-train help (nerfstudio-project#1370) * Improve ns-process-data images when using existing COLMAP model (nerfstudio-project#1371) * Allow skipping copy+downscale of images in ns-process-data, fix bug when using --skip-colmap on images.bin with non-standard image names * Rename flags and improve error messages --------- Co-authored-by: Matthew Tancik <tancik@berkeley.edu> --------- Co-authored-by: Matthew Tancik <tancik@berkeley.edu> Co-authored-by: Jeffrey Hu <102542936+jeffreyhuparallel@users.noreply.github.com> Co-authored-by: machenmusik <machenmusik@users.noreply.github.com> Co-authored-by: ManuConcepBrito <33829944+ManuConcepBrito@users.noreply.github.com> Co-authored-by: Francisca T. Gil Ureta <124404718+gilureta@users.noreply.github.com> Co-authored-by: gilureta <gilureta@amazon.com> Co-authored-by: Jonáš Kulhánek <jonas.kulhanek@live.com>
chris838
pushed a commit
to chris838/nerfstudio
that referenced
this pull request
Apr 22, 2023
…dio-project#1358) If running local server instance, avoid using relays to communicate with the viewer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If running local server instance, avoid using relays to communicate with the viewer.