Add depth_unit_scale_factor to sdfstudio_dataparser #2285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depth supervision for `depth-nerfacto` was added in nerfstudio-project#1173. This patch extends that support to `sdfstudio` datasets ([as originally intended](nerfstudio-project#1173 (comment))) by adding `depth_unit_scale_factor` to `sdfstudio` metadata.
|
Seems good to me, hoping @AdamRashid96 can comment since he has more experience w/ the depth datasets |
AdamRashid96
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depth supervision for
depth-nerfactowas added in #1173.This patch extends that PR to support
sdfstudiodatasets (as originally intended) by addingdepth_unit_scale_factortosdfstudiometadata.