-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default delta updater can delta non-block resources #886
Default delta updater can delta non-block resources #886
Conversation
See fwup-home/fwup#202 for fwup related PR |
0f72d6b
to
bcebab3
Compare
@jeanparpaillon Thanks! This looks great. I'm working with @oestrich and @jjcarstens to get this change in. We're in an awkward place where we're doing a lot of testing with a modified version of NervesHub. See https://github.com/nerves-hub/nerves_hub_web/commits/2.0. We're working on docs and updates to describe the direction we're going in 2.0. The main reason for 2.0, though, is to let us break compatibility in a few areas to make implementing some features we really want much easier. In summary, I suspect that we merge your PR to |
@fhunleth thanks for the heads up. You may have noticed I have arbitrarily set a minimal fwup version in the code that need to be adjusted with regard to the PR in fwup. |
Requires fwup >= 1.10.0 Closes nerves-hub#885
bcebab3
to
cce6162
Compare
@fhunleth I've identified a bug in the code and just updated the PR: when creating firmware archive, ensure meta.conf. and meta.conf are the first files in the archive |
@fhunleth same fix pushed to nerves-project/nerves#857 |
FYI - I switched the destination branch to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So sorry this took so long! Will add to main
shortly as well
👍 |
Requires fwup >= 1.10.0
Closes #885