Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for building systems on macOS, and $TMPDIR #951

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

schrockwell
Copy link

This is a follow-up to #876 and nerves-project/nerves_system_br#778 that adds documentation specifically about building custom systems on macOS, and the new $TMPDIR environment variable.

Should the docs recommend setting both $NERVES_DL_DIR and $NERVES_ARTIFACTS_DIR, or should we just set $XDG_DATA_HOME?

@fhunleth fhunleth requested a review from jjcarstens February 7, 2024 18:09
@fhunleth
Copy link
Member

fhunleth commented Feb 7, 2024

I don't have opinions here so long as it works. My plan would be to merge after new official Nerves systems are available with the nerves_system_br fix.

@schrockwell
Copy link
Author

Yup, I think that all makes sense. Thanks.

@jjcarstens
Copy link
Member

Why do the download and artifact directories need to be on the volume? I thought all that might be needed is TMPDIR since the build and mktemp would be using the copied temp files which would be available in case sensitive?

I don't think NERVES_DL_DIR needs to be recommended since that is just compressed tar and zip files. NERVES_ARTIFACTS_DIR is fine but we could also say XDG_DATA_HOME would be recommended since that would handle all the Nerves pieces

@schrockwell
Copy link
Author

@jjcarstens You may be right about downloads, but for artifacts I did find conflicts such as

/Volumes/Nerves/artifacts/nerves_system_rpi3a_tailscale-portable-1.25.1/staging/usr/lib/xtables/libip6t_hl.so
/Volumes/Nerves/artifacts/nerves_system_rpi3a_tailscale-portable-1.25.1/staging/usr/lib/xtables/libip6t_HL.so

I'm happy to change it to XDG_DATA_HOME to make it simpler and potentially more future-proof.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants