-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/default tx builder step1 #53
Closed
liuck8080
wants to merge
24
commits into
nervosnetwork:master
from
liuck8080:feat/default_tx_builder_step1
Closed
Feat/default tx builder step1 #53
liuck8080
wants to merge
24
commits into
nervosnetwork:master
from
liuck8080:feat/default_tx_builder_step1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The doa.rs is bigger, move to a directory can add submodule easily
1. add macro impl_default_builder to save code rewrite for default simple transaction builder; 2. SUDT update transfer need more than 1 keys to update exist cell;
add example for DefaultChequeWithdrawBuilder and DefaultChequeClaimBuilder
1. Add cheque claim examples for create cell with specified capacity and for update cell with target cell's capacity for fee; 2. Fix the problem if the first queried sender cell without amount will block the udt transfer.
fix a lint problem, remove unnecessary clone() function.
liuck8080
force-pushed
the
feat/default_tx_builder_step1
branch
from
March 9, 2023 13:18
6ebbe67
to
40d2702
Compare
This PR is too big, so i create #59 to only contain examples/send_ckb_example.rs and examples/send_ckb_multisig_example.rs, hope that will reduce the review work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
How does it tested.