Feat/refact build sign send 20230418 #66

liuck8080 · 2023-04-25T07:22:52Z

What does this PR do

A ckb-sdk-java style transaction builder;
Separate transaction build process into build, sign, send;
define action to handle small change capacity;

first time can pass the compile

fix typo of example name; add function to register test context;

If change is not enough to create a change cell, define actions to find more input, or send to output, or as extra fee.

examples/send_ckb_example.rs

src/transaction/input/mod.rs

src/transaction/builder/tx_data.rs

src/transaction/handler/mod.rs

src/transaction/builder/mod.rs

Move TxData to patch mod, rename to TransactionBuilder, so late can be easily repalaced with core::TransactionBuilder, all missing functions should added in ckb_types module.

src/transaction/builder/mod.rs

Liu Chuankai added 8 commits April 23, 2023 23:29

feat: 🎸 add transaction mod as java-sdk like builder

3127149

first time can pass the compile

fix: 🐛 take change size into count

974abd9

fix: 🐛 now can search input one by one

556f5b0

feat: 🎸 sighash handler can add deps and witness

feb3ac8

feat: 🎸 CKBScriptSigner can sign

edf956d

fix: 🐛 fix change capacity 0 problem

aef2a54

fix: 🐛 fix few problems

019d04a

fix typo of example name; add function to register test context;

feat: 🎸 define action to handle small change

cd82985

If change is not enough to create a change cell, define actions to find more input, or send to output, or as extra fee.

liuck8080 requested a review from quake April 25, 2023 07:22

quake requested changes May 6, 2023

View reviewed changes

refactor: 💡 fix review problems in PR nervosnetwork#66

205c095

quake reviewed May 6, 2023

View reviewed changes

src/transaction/builder/mod.rs Show resolved Hide resolved

Liu Chuankai added 5 commits May 8, 2023 23:44

fix: 🐛 Fix the problem a script can find only one item

ec70839

refactor: 💡 prepare replace TxData with TransactionBuilder

5663002

Move TxData to patch mod, rename to TransactionBuilder, so late can be easily repalaced with core::TransactionBuilder, all missing functions should added in ckb_types module.

refactor: 💡 use ckb-sdk-rust version transaction builder

6699584

test: 💍 Add unittests for SimpleTransactionBuilder of sighash

99efe7d

test: 💍 Make example use different receiver and sender address

7c22740

liuck8080 mentioned this pull request May 10, 2023

simple multisig transaction builder #68

Merged

fix: 🐛 fix some typoes and problems

b0f0b25

quake reviewed May 11, 2023

View reviewed changes

src/transaction/builder/mod.rs Outdated Show resolved Hide resolved

Liu Chuankai added 2 commits May 11, 2023 14:50

chore: 🤖 rename tx_data to tx_builder

b0f6308

chore: 🤖 change tx_data to tx_builder

8092d48

quake approved these changes May 11, 2023

View reviewed changes

liuck8080 merged commit dce6a42 into nervosnetwork:master May 11, 2023

liuck8080 pushed a commit that referenced this pull request May 11, 2023

refactor: 💡 fix review problems in PR #66

7026b7f

liuck8080 deleted the feat/refact_build_sign_send_20230418 branch May 11, 2023 09:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/refact build sign send 20230418 #66

Feat/refact build sign send 20230418 #66

liuck8080 commented Apr 25, 2023 •

edited

Loading

Feat/refact build sign send 20230418 #66

Feat/refact build sign send 20230418 #66

Conversation

liuck8080 commented Apr 25, 2023 • edited Loading

What does this PR do

liuck8080 commented Apr 25, 2023 •

edited

Loading