Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use fixed size array and smaller buffer size to load data #49

Merged
merged 2 commits into from
May 18, 2023
Merged

refactor: use fixed size array and smaller buffer size to load data #49

merged 2 commits into from
May 18, 2023

Conversation

quake
Copy link
Member

@quake quake commented May 12, 2023 •
edited
Loading

  1. CellInput and Header are fixed size struct, no need to use buffer to load data.
  2. Tweak default buffer size to smaller one to reduce the cycle.

@quake quake force-pushed the quake/small-buffer branch from 6117338 to 9470ccf Compare May 12, 2023 07:20
@quake quake requested a review from jjyr May 12, 2023 07:20
@quake quake force-pushed the quake/small-buffer branch from 9470ccf to 27822d1 Compare May 12, 2023 10:52
@quake quake force-pushed the quake/small-buffer branch from 27822d1 to a7c5818 Compare May 12, 2023 11:00
@jjyr jjyr merged commit c05aaae into nervosnetwork:master May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjyr jjyr jjyr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@quake @jjyr