-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce launcher #2613
Merged
bors
merged 2 commits into
nervosnetwork:develop
from
zhangsoledad:zhangsoledad/refactor-initialize
Mar 26, 2021
Merged
Introduce launcher #2613
bors
merged 2 commits into
nervosnetwork:develop
from
zhangsoledad:zhangsoledad/refactor-initialize
Mar 26, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangsoledad
requested review from
doitian,
quake and
yangby-cryptape
as code owners
March 12, 2021 05:56
zhangsoledad
force-pushed
the
zhangsoledad/refactor-initialize
branch
from
March 12, 2021 06:00
1aa6622
to
853eaf5
Compare
yangby-cryptape
previously approved these changes
Mar 12, 2021
quake
previously approved these changes
Mar 12, 2021
zhangsoledad
dismissed stale reviews from quake and yangby-cryptape
via
March 12, 2021 08:05
c05c0a3
yangby-cryptape
previously approved these changes
Mar 12, 2021
quake
previously approved these changes
Mar 18, 2021
bors r=yangby-cryptape,quake |
bors bot
added a commit
that referenced
this pull request
Mar 18, 2021
2613: Introduce launcher r=yangby-cryptape,quake a=zhangsoledad this PR mainly simplified the launch code https://github.com/nervosnetwork/ckb/blob/853eaf5ab5f5a9b678f496abb74cf576a3501804/ckb-bin/src/subcommand/run.rs#L11-L62 Co-authored-by: zhangsoledad <787953403@qq.com>
Build failed: |
bors retry |
bors bot
added a commit
that referenced
this pull request
Mar 19, 2021
2613: Introduce launcher r=yangby-cryptape,quake a=zhangsoledad this PR mainly simplified the launch code https://github.com/nervosnetwork/ckb/blob/853eaf5ab5f5a9b678f496abb74cf576a3501804/ckb-bin/src/subcommand/run.rs#L11-L62 Co-authored-by: zhangsoledad <787953403@qq.com>
Build failed: |
bors retry |
bors bot
added a commit
that referenced
this pull request
Mar 19, 2021
2613: Introduce launcher r=yangby-cryptape,quake a=zhangsoledad this PR mainly simplified the launch code https://github.com/nervosnetwork/ckb/blob/853eaf5ab5f5a9b678f496abb74cf576a3501804/ckb-bin/src/subcommand/run.rs#L11-L62 Co-authored-by: zhangsoledad <787953403@qq.com>
Build failed:
|
zhangsoledad
dismissed stale reviews from quake and yangby-cryptape
via
March 25, 2021 04:12
bb1e050
zhangsoledad
force-pushed
the
zhangsoledad/refactor-initialize
branch
2 times, most recently
from
March 25, 2021 04:43
bb1e050
to
dbef17a
Compare
zhangsoledad
force-pushed
the
zhangsoledad/refactor-initialize
branch
from
March 26, 2021 05:54
dbef17a
to
59390a1
Compare
yangby-cryptape
previously approved these changes
Mar 26, 2021
zhangsoledad
force-pushed
the
zhangsoledad/refactor-initialize
branch
from
March 26, 2021 06:31
38b39b3
to
8b34fc6
Compare
quake
approved these changes
Mar 26, 2021
yangby-cryptape
approved these changes
Mar 26, 2021
bors r=yangby-cryptape,quake |
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR mainly simplified the launch code
ckb/ckb-bin/src/subcommand/run.rs
Lines 11 to 62 in 853eaf5