feat: Fix download scheduler #2628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
driftluo
commented
Mar 24, 2021
driftluo
commented
- disable penalty when download nodes are scarce
- allow the protection node to be disconnected due to sync judgment
driftluo
requested review from
keroro520,
quake and
zhangsoledad
as code owners
quake
reviewed
Mar 25, 2021
driftluo
force-pushed
the
fix-download-scheduler
branch
from
40393eb to
34055d6
Compare
quake
approved these changes
Mar 25, 2021
doitian
reviewed
Apr 15, 2021
| // | ||
| // In order to protect the decentralization of the network and ensure the survival of low-performance | ||
| // nodes, the penalty mechanism will be closed when the number of download nodes is less than the number of protected nodes | ||
| let should_punish = self.download_schedulers.len() > self.protect_num; |
There was a problem hiding this comment.
Just a small suggestion: this can be extracted as a small function self.should_punish()
doitian
approved these changes
Apr 15, 2021
|
bors r=quake,doitian |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.