Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: compatibility policy for configuration files #2822

Merged

Conversation

yangby-cryptape
Copy link
Collaborator

@yangby-cryptape yangby-cryptape commented Jul 13, 2021

Compatibility Policy for Configuration Files

  • Deny unknown configuration items.

    To avoid several kinds of mistakes, for example, typos.

  • Allow deprecated configuration items, but they will be ignored; and warning messages will be output.
    After several versions, if these deprecated items satisfied any of the following conditions, they will be fully removed (denied):

    • Not list in the default configuration files.
    • Be tagged as "Experimental".
  • The default configuration files will not include any deprecated configuration items.

  • The default configuration files will not enable any experimental configuration items.

@yangby-cryptape yangby-cryptape marked this pull request as ready for review July 13, 2021 06:41
@yangby-cryptape yangby-cryptape requested a review from a team July 13, 2021 06:41
@yangby-cryptape yangby-cryptape requested a review from a team as a code owner July 13, 2021 06:41
@yangby-cryptape yangby-cryptape mentioned this pull request Jul 13, 2021
10 tasks
@doitian
Copy link
Member

doitian commented Jul 13, 2021

bors r=quake,doitian,zhangsoledad

@bors
Copy link
Contributor

bors bot commented Jul 13, 2021

Build succeeded:

@bors bors bot merged commit 7ba0c69 into nervosnetwork:develop Jul 13, 2021
@yangby-cryptape yangby-cryptape deleted the pr/refactor-configurations branch July 14, 2021 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants