feat: better tips for "migrate" subcomamnd #2854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangby-cryptape
force-pushed
the
pr/better-tips
branch
from
597d817 to
0b65cea
Compare
doitian
approved these changes
Jul 21, 2021
doitian
requested changes
Jul 21, 2021
yangby-cryptape
force-pushed
the
pr/better-tips
branch
from
0b65cea to
f195471
Compare
driftluo
approved these changes
Jul 23, 2021
doitian
approved these changes
Jul 23, 2021
|
bors merge=driftluo,doitian |
bors bot
added a commit
that referenced
this pull request
Jul 23, 2021
2854: feat: better tips for "migrate" subcomamnd r=driftluo,doitian a=yangby-cryptape 2864: chore(deps): upgrade several dependencies to remove tokio less than v1.0 r=quake,driftluo a=yangby-cryptape ### Purpose Remove almost all tokio whose version is less than v1.0. #### To Be Continued This PR still left one dependency which is depended on tokio v0.2, because that upgrade will change a lot of code, I prefer to put that in another PR later. ### Changes - Bump jsonrpc-* from 0.17.1 to 0.18.0. - Bump reqwest from 0.10.9 to 0.11.4. - Bump hyper from 0.13 to 0.14. - Bump hyper-tls from 0.4 to 0.5. - Bump trust-dns-resolver from 0.19 to 0.20. - Bump ckb-sentry 0.21.0 to sentry 0.23.0. - We fork sentry for [RUSTSEC-2020-0041](https://rustsec.org/advisories/RUSTSEC-2020-0041.html), now that issue was fixed. - Use `std::sync::mpsc::sync_channel(1)` instead of `tokio::sync::oneshot::channel()` in `tx_pool`. - To fix error "Cannot start a runtime from within a runtime." after upgrading RPC server's tokio. - JSON RPC server doesn't allow to use customize tokio executor. Even there are APIs: [`pub fn event_loop_executor(self, executor: tokio::Handle) -> Self;`](https://docs.rs/jsonrpc-http-server/18.0.0/jsonrpc_http_server/struct.ServerBuilder.html#method.event_loop_executor) - Use `block_in_place(|| response.recv())` instead of `self.handle.block_on(response)`. Without `block_in_place`, RPC service will be blocked very frequently. Co-authored-by: Boyu Yang <yangby@cryptape.com>
|
Build failed (retrying...): |
|
Build succeeded: |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.