Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): make sure testnode graceful shutdown basic sync #2924

Merged

Conversation

zhangsoledad
Copy link
Member

@zhangsoledad zhangsoledad commented Aug 10, 2021

tests::synchronizer::basic_sync do not graceful shutdown, may cause

pure virtual method called                                                                                                                                                                   
terminate called without an active exception 

bump crossbeam-channel from 0.3.9 to 0.5.1 incidentally.

Closes #2927

@zhangsoledad zhangsoledad requested a review from a team as a code owner August 10, 2021 10:36
@yangby-cryptape
Copy link
Collaborator

bors r=quake,yangby-cryptape

@bors
Copy link
Contributor

bors bot commented Aug 10, 2021

Build succeeded:

@bors bors bot merged commit 63f0d31 into nervosnetwork:develop Aug 10, 2021
@doitian doitian mentioned this pull request Aug 23, 2021
3 tasks
@doitian doitian mentioned this pull request Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit test failed because of error "pure virtual method called"
4 participants