Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ckb-resource): Remove dependency on tempfile in ckb-resource #2948

Merged
merged 1 commit into from
Aug 16, 2021
Merged

refactor(ckb-resource): Remove dependency on tempfile in ckb-resource #2948

merged 1 commit into from
Aug 16, 2021

Conversation

chanhsu001
Copy link
Contributor

write target file directly; append .tmp.$PID to the target file as the tmp file

@chanhsu001 chanhsu001 requested a review from a team as a code owner August 14, 2021 02:46
quake
quake requested changes Aug 15, 2021
View reviewed changes
Copy link
Member

@quake quake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check the ci error, the changes of Cargo.lock file should be checked-in also.

quake
quake reviewed Aug 15, 2021
View reviewed changes
resource/src/lib.rs Outdated Show resolved Hide resolved
@chanhsu001
refactor(ckb-resource): Remove dependency on tempfile in ckb-resource
f7a613d 
write target file directly without tempfile created.
@yangby-cryptape
Copy link
Collaborator

bors merge=quake,yangby-cryptape

@bors
Copy link
Contributor

bors bot commented Aug 16, 2021

Build succeeded:

@bors bors bot merged commit b4620e0 into nervosnetwork:develop Aug 16, 2021
@doitian doitian mentioned this pull request Aug 23, 2021
Closed
3 tasks
@chanhsu001 chanhsu001 deleted the remove_dep_tempfile_of_ckbresource branch August 25, 2021 10:30
@doitian doitian mentioned this pull request Sep 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yangby-cryptape yangby-cryptape yangby-cryptape approved these changes

@quake quake quake approved these changes

@doitian doitian Awaiting requested review from doitian

@keroro520 keroro520 Awaiting requested review from keroro520

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chanhsu001 @yangby-cryptape @quake