fix: tx-pool snapshot consistency #2984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangsoledad
force-pushed
the
zhangsoledad/fix-template
branch
from
bd42250 to
52d3727
Compare
zhangsoledad
force-pushed
the
zhangsoledad/fix-template
branch
from
52d3727 to
55a5dcb
Compare
zhangsoledad
force-pushed
the
zhangsoledad/fix-template
branch
from
55a5dcb to
250baf3
Compare
zhangsoledad
force-pushed
the
zhangsoledad/fix-template
branch
from
a87b64f to
dedb3f1
Compare
driftluo
approved these changes
Sep 6, 2021
|
i' not qulified to review this pr for i'm not familiar with this part. Could change to other one to reivew? |
driftluo
requested review from
quake and
yangby-cryptape
and removed request for
chanhsu001
yangby-cryptape
approved these changes
Sep 9, 2021
|
bors r=yangby-cryptape,driftluo |
|
Build succeeded: |
bors bot
added a commit
that referenced
this pull request
Oct 2, 2021
3068: fix: block-template test r=quake,driftluo a=zhangsoledad <!-- Thank you for contributing to nervosnetwork/ckb! If you haven't already, please read [CONTRIBUTING](https://github.com/nervosnetwork/ckb/blob/develop/CONTRIBUTING.md) document. If you're unsure about anything, just ask; somebody should be along to answer within a day or two. PR Title Format: 1. module [, module2, module3]: what's changed 2. *: what's changed --> ### What problem does this PR solve? Problem Summary: Since #2984, if tx-pool does not sync with chain yet, a blank template will return by request. this may lead to some block-template tests failed randomly. ### What is changed and how it works? What's Changed: Make block-template tests block on status sync. ### Related changes - PR to update `owner/repo`: - Need to cherry-pick to the release branch ### Check List <!--REMOVE the items that are not applicable--> Tests <!-- At least one of them must be included. --> - Unit test ### Release note <!-- Choose from None, Title Only and Note. Bugfixes or new features need a release note. --> ```release-note None: Exclude this PR from the release note. ``` Co-authored-by: zhangsoledad <787953403@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Previously, tx-pool has a potential issue, some code gets snapshots directly from the
ArcSwapcontainer, which means those snapshots represent the newest chain, it may be inconsistent with tx-pool owned snapshot.What is changed and how it works?
Remove interface that can get snapshot from swap container.
https://github.com/nervosnetwork/ckb/pull/2984/files#diff-fb91da4f07a6ef121b8913771dd0cf067853b6a3b41eaa96fd242881b71b5f32L659-L664
Check List
Tests
https://github.com/nervosnetwork/ckb/pull/2984/files#diff-6dd28380157411935dbe8b390f7a324dc57b8a8654f9276cb83e2cfca8df36f4R618-R641
Release note