fix: shouldn't override the log.file
after touch it
#3011
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Since #2990, the log service will write logs into
log.dir + log.file
.But the
log.file
is overridden tolog.dir + log.file
aftertouch
.Then the log service will write logs into
log.dir + log.dir + log.file
.Related changes
rc/v0.100
release branchCheck List
Tests
Manual test
ckb init -C /tmp/ckb-dir
ckb run -C /tmp/ckb-dir
cat /tmp/ckb-dir/data/logs/run.log
ckb miner -C /tmp/ckb-dir
cat /tmp/ckb-dir/data/logs/miner.log
cd /tmp
ckb init -C ckb-dir
ckb run -C ckb-dir
cat ckb-dir/data/logs/run.log
ckb miner -C ckb-dir
cat ckb-dir/data/logs/miner.log
cd /tmp
ckb init -C ckb-dir
cd ckb-dir
ckb run -C .
cat data/logs/run.log
ckb miner -C .
cat data/logs/miner.log
Release note